-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bring @gmponos PR forward with master #668
base: master
Are you sure you want to change the base?
Conversation
Co-Authored-By: Márk Sági-Kazár <sagikazarmark@users.noreply.github.com>
Right, got that to pass everything but the mutation tests. I don't really know how to fix those (a lot of what it flags isn't stuff I've changed). |
Great work @jameswilddev and @gmponos (!). To what extend is the exponential parser also able to parse normal numbers? |
I'll be honest I haven't looked at the base PR in depth; I've only checked out the branch, merged master and fixed CI failures. In my case I'm maintaining a product which uses Money and found a bug where entering "1e1" would get past validation, but then cause a parser error and figured this could well be fix. |
What is the use again of this Parser/Formatter? Maybe it is time to merge this in after 4 years..... sorry guys! |
Hi, haven't fully understood the question.
Not sure if I miss something.. sorry |
This is identical to #520 but caught up with master.